Merged
Conversation
Sync to USWDS folder structure
**Why**: So that existing intended styles are applied as expected.
anniehirshman-gsa
approved these changes
Feb 1, 2022
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
LGTM III - much improved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that existing intended styles are applied as expected.
In #240, we customized the external link icon margins to increase spacing relative to surrounding content. This regressed as part of the recent upgrade to USWDS v2.13.1, which modified how external link icons were styled in a manner incompatible with our previous revisions.
The changes included here restore the intended margin effect.
Screenshot:
These screenshots show links in context of the IdP IAL2 flow. In particular, note the "Learn more" link in the last paragraph of the content.