Skip to content

Match usa-input-error selector to USWDS #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 3 commits into from
Nov 23, 2021
Merged

Match usa-input-error selector to USWDS #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6aba36
Match usa-input-error selector to USWDS
aduth Nov 22, 2021
629351b
Add CHANGELOG note
aduth Nov 22, 2021
fe18408
Reorder CHANGELOG bug fixes > dependencies
aduth Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
- Form hint text is now shown with an italicized style and increased vertical margins. ([#262](https://github.com/18F/identity-style-guide/pull/262))
- Icons for form validation errors are aligned to the top ([#265](https://github.com/18F/identity-style-guide/pull/265))

### Bug Fixes

- Fix an issue where `.usa-input--error` would apply the incorrect border color unless also accompanied by `.usa-input`, `.usa-textarea`, or `.usa-select`. ([#275](https://github.com/18F/identity-style-guide/pull/275))

### Dependencies

- Upgraded USWDS from v2.12.1 to v2.12.2 (see [release notes](https://github.com/uswds/uswds/releases/tag/v2.12.2)) ([#269](https://github.com/18F/identity-style-guide/pull/269))
Expand Down
6 changes: 3 additions & 3 deletions src/scss/components/_inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ $input-select-margin-right: 1;
@include disable-default-focus-styles;
box-shadow: roundable-focus-outline-box-shadows();
}
}

&.usa-input--error {
@include u-border-color('error');
}
.usa-input--error {
@include u-border-color('error');
}

[type='search'],
Expand Down