Add "Coding Standards" section to contributing guide#271
Merged
Conversation
**Why**: To better communicate the approach to extending USWDS.
aduth
added a commit
that referenced
this pull request
Nov 22, 2021
**Why**: The error input selector in USWDS does not qualify as one of `.usa-input`, `.usa-textarea`, or `.usa-select`. In many cases, this makes little difference since the modifier would be applied to an element with one of those classes. However, this is not strictly required, and causes some challenge in the IdP with SimpleForm compatibility. Furthermore, per updated guidance in #271, selectors with overriding styles should seek to precisely match the USWDS selector it is overriding. Future work should seek to bring stylesheet files into closer alignment with USWDS files where these styles are defined (tracked in LG-5398).
aduth
added a commit
that referenced
this pull request
Nov 23, 2021
* Match usa-input-error selector to USWDS **Why**: The error input selector in USWDS does not qualify as one of `.usa-input`, `.usa-textarea`, or `.usa-select`. In many cases, this makes little difference since the modifier would be applied to an element with one of those classes. However, this is not strictly required, and causes some challenge in the IdP with SimpleForm compatibility. Furthermore, per updated guidance in #271, selectors with overriding styles should seek to precisely match the USWDS selector it is overriding. Future work should seek to bring stylesheet files into closer alignment with USWDS files where these styles are defined (tracked in LG-5398). * Add CHANGELOG note * Reorder CHANGELOG bug fixes > dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To better communicate the approach to extending USWDS.