LG-4226: Add explicit flexible width button modifier#197
Merged
Conversation
**Why**: As a consumer of the login.gov Design System, I expect to be able to override the default full-width button appearance on mobile to allow for flexible-width buttons, so that I can create interfaces where the button is shown adjacent to other text or controls. Currently, all buttons are shown as full-width at mobile viewports. There are a few instances in the IDP of buttons appearing as "flexible width", with text or interactive content shown next to the button. These are not the majority, so an override option is included to let the developer choose to force the width to shrink as flexible, while retaining the current default behavior. In discussing this with @anniehirshman-gsa , it was considered whether a similar exception override class should be included for minimum-width buttons (e.g. `usa-button--minimum-width`). There are currently no use-cases for this, so it was decided to defer this for future consideration if ever it becomes relevant.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a consumer of the login.gov Design System, I expect to be able to override the default full-width button appearance on mobile to allow for flexible-width buttons, so that I can create interfaces where the button is shown adjacent to other text or controls.
Currently, all buttons are shown as full-width at mobile viewports. There are a few instances in the IDP of buttons appearing as flexible width at mobile viewport sizes, with text or interactive content shown next to the button (example). These are not the majority, so an override option is included to let the developer choose to force the width to shrink as flexible, while retaining the current default behavior.
In discussing this with @anniehirshman-gsa , it was considered whether a similar exception override class should be included for minimum-width buttons (e.g.
usa-button--minimum-width). There are currently no use-cases for this, so it was decided to defer this for future consideration if ever it becomes relevant.Live Preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-mobile-flex-width-button/components/buttons/#button-widths
Screenshot: