Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include message in object response if v1.1 #225

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

scottqueen-bixal
Copy link
Contributor

This update includes a conditional that adds a message on the result object when a request is made to the v1.1 endpoint

fixes #224

Copy link
Contributor

@XavierMetichecchia XavierMetichecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@scottqueen-bixal scottqueen-bixal merged commit 30a4fba into develop Jan 19, 2024
3 checks passed
@smarina04
Copy link

@scottqueen-bixal since we are still technically supporting v1 via API, the current message is confusing. Pls change this part of the message "'v1 is no longer supported." to "v1 will be deprecated in June 2024." The rest is good. Thanks @ryanwoldatwork for catching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include messaging in response on v1.1 requests
3 participants