Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure 'serde' feature also enables 'glam/serde' #4

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Make sure 'serde' feature also enables 'glam/serde' #4

merged 1 commit into from
Oct 19, 2024

Conversation

VictorKoenders
Copy link
Contributor

This makes it so that if you enable the serde feature, structs like Vec2 correctly implement (de)serialize

17cupsofcoffee
17cupsofcoffee approved these changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible change! dep:serde wasn't a thing when I made Tetra, so I had to call the feature something else there - this looks a lot nicer 😄

@17cupsofcoffee 17cupsofcoffee merged commit c5a13b8 into 17cupsofcoffee:main Oct 19, 2024
@VictorKoenders VictorKoenders deleted the serde-glam branch October 29, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorKoenders @17cupsofcoffee