-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created intermediate enum for events #3
Created intermediate enum for events #3
Conversation
…e underlying glow handle, added a way to get the total duration of the app
Sorry for delay on reviewing this, dayjob has been a bit crazy recently! I will try to get to it soon :) |
No worries, take your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks like reasonable changes to me - the only bit I'm mulling over slightly is the controller events returning joystick IDs (as there's nowhere else in the API you can actually use those - all the Input
methods take a zero-indexed gamepad ID, so that you can just say 'gamepad 0' to get the first one that was plugged in).
It's a bit of a chicken and egg problem though, as at the point we convert from SDL event to our Event
, we haven't assigned those gamepad IDs yet! So maybe it does make sense this way...
I'll give it some thought, and if I don't have any better ideas I'll merge as is 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go with this as-is for now - can always tweak it later if I figure out a different approach to the gamepad stuff.
Thanks for the PR (and the patience waiting weeks for me to review it 😅)
Don't worry about it, thank you for making nova! 🙂 |
Event
enum that also gets send to theEventHandler
app.timer.total_time()
glow
handleArc<>
for https://docs.rs/egui_glow/latest/egui_glow/painter/struct.Painter.html#method.newWindowResized
that gets triggered when a window gets resizedGamepad
a wrapper aroundRc<GamepadInner>
so this could be cloneable (since it's used inEvent
)RightShift
,RightCtrl
,RightAlt
,LeftCommand
, andRightCommand