Check Error.cause for TemplateContentPrematureUseError when rendering
#3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e?.originalError?.originalError performs sufficient check for `TemplateContentPrematureUseError`
in e?.cause in addition to other cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may address the issue of #2328, and resolves a downstream issue in noelforte/eleventy-plugin-vento#120.
I've patched the static method
EleventyErrorUtil.isPrematureTemplateContentErrorto search for instances ofTemplateContentPrematureUseErrors withinError.causeas well, so rethrown errors (from a Custom Template Language in my case) are properly caught by Eleventy.As work on #3582 continues, the implementation here could probably be cleaned up even more but I figured I'd start with this single patch.
I've also added additional changes in separate commits for the following:
?.)originalError.namethat didn't seem to have any effect sinceoriginalError.originalErroris what we're actually looking to identify. Unless of courseTemplateContentPrematureUseErrors can be thrown in cases that are notRenderErrors orUndefinedVariableErrors, in which case you can drop that commit.Let me know if there's any changes!