-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes stopWatch() async and graceful. #3361
Conversation
Shipping with 3.0.0-alpha.17 Thank you!! |
FYI I did need to revert the |
Weird. All tests I did were successful. Did you try with the PR in eleventy-dev-server? Current server isn't async. |
This isn’t a currently tested scenario, unfortunately. Can you check the changes I made linked above and see if they still align? I don’t expect that we’ll need to revert any of the async changes you made, it was only the |
I'm sorry, my description of this PR should have been more thorough. This PR goes hand in hand with my PR in eleventy-dev-server (11ty/eleventy-dev-server#85). They need each other to work properly. Applying only one but not the other doesn't improve anything, unfortunately. Regarding the process not stopping, my best guess is: The current dev-server doesn't close the WebSocket connection(s), which would prevent a clean exit. Reintroducing Please let me know if I can support you in any way. |
Restored your original changes and they’ll ship with Dev Server v2.0.2 in 3.0.0-alpha.18—thank you so much! |
That's awesome! Thank you! |
This is the counterpart to 11ty/eleventy-dev-server#85.