Updated actions for docker hub to build and publish develop version

[eugene-manuilov]

Description of the Change

Reworked GitHub Actions workflow for docker hub images to support docker images for develop branch.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Changelog Entry

[helen]

I noticed in your other PR that you ended up moving away from Docker's actions - is there any reason why? I'm wary of echoing out the access token like this, GH does its best to mask any it detects from log output but still seems like an unnecessary risk if we can make it work with actions that take them as inputs.

[eugene-manuilov]

I noticed in your other PR that you ended up moving away from Docker's actions - is there any reason why?

Which PR do you mean, @helen? Can you link it?

I'm wary of echoing out the access token like this, GH does its best to mask any it detects from log output but still seems like an unnecessary risk if we can make it work with actions that take them as inputs.

It's a good point. I have updated it to use secrets as environment variables which seems to be sufficient based on the GitHub Actions documentation.

[tlovett1]

As long as we are confident this isn't printing secrets to the logs, I'm good to merge.

[eugene-manuilov]

I have added dummy secrets to my fork and can confirm that GitHub doesn't expose it when I check the log: