-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions to build and push a new docker image when a new release is published #72
Conversation
@eugene-manuilov This is super cool and I'm really happy we have this automatically running in Actions. I have just a few questions....
|
I have never worked with the official docker actions before. Plus, I found it a little bit confusing when I tried it at the beginning. Now, I think I agree with you and will give it another try next week.
The current |
@TheLastCicada i have updated GitHub actions to use the official Docker actions for it. All works perfectly. |
Description of the Change
This PR adds a new GitHub Actions file that builds and pushes a new docker image when a release is published. When it builds a docker image, it uses a tarball archive generated by GitHub and associated with the release. It also tags the new image with the release name and a major version. For example, when
2.1.0
release is published, it will create a new image with the following tags:latest
,2.1.0
, and2
.The docker image itself is different from one that is currently used by the 10up/wp-local-docker-images. Probably, it is worth asking a system engineer to check it and provide feedback.
To make GitHub actions work correctly, we need to add two variables to this repo secrets:
DOCKERHUB_ACCESS_TOKEN
DOCKERHUB_USERNAME
. The first one should contain an access token generated in the docker hub, and the second one should contain a username used in the docker hub.Checklist: