Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: --format option and search for multiple queries #70

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Search: --format option and search for multiple queries #70

merged 4 commits into from
Sep 17, 2020

Conversation

eugene-manuilov
Copy link
Collaborator

@eugene-manuilov eugene-manuilov commented Sep 8, 2020

Description of the Change

Updated search command to allow searching using multiple queries and added --format option that supports json and table options. Multiple queries search is important for the new version of wp-local-docker because it will help to get information about multiple snapshots using just one command. The --format option is added for the same reason - to simplify integration with the new version of wp-local-docker.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Run the following command to get information about two snapshots using their ids:

wpsnapshots search b719bef1c09e0d2f654aa52008307a20 5639b553a97c74f54af0ecf2ae85f7a9

Same command but with json output:

wpsnapshots search b719bef1c09e0d2f654aa52008307a20 5639b553a97c74f54af0ecf2ae85f7a9 --format=json

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

  • Changed the search command arguments to allow multiple queries.
  • Added --format option to the search command that accepts json and table values.
  • Fixed empty line issue rendered at the beginning of all commands.

@tlovett1
Copy link
Member

tlovett1 commented Sep 8, 2020

@eugene-manuilov thanks for creating this! Can you update the docs with the changes?

@eugene-manuilov
Copy link
Collaborator Author

@tlovett1, updated, does it look good now?

@tlovett1
Copy link
Member

Works well.

@tlovett1 tlovett1 merged commit 35029a6 into 10up:develop Sep 17, 2020
@jeffpaul jeffpaul added this to the 2.1.0 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants