Disable client side monitoring #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlovett1
approved these changes
Jan 18, 2020
|
I wasn't able to reproduce the problem but will merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Disables Client Side Monitoring. Support for CSM Configuration was added to the AWS SDK in aws/aws-sdk-php#1834. Recently our users have been getting the following errors when attempting to push snapshots:
Error Message: CSM 'port' value must be an integer!This pull requests disables CSM as per the AWS SDK spec.
Alternate Designs
Benefits
Possible Drawbacks
I'm not exactly sure what Client Side Monitoring does, so disabling it might have unintended affects.
Verification Process
Testing in progress
Checklist:
Changelog Entry