-
Notifications
You must be signed in to change notification settings - Fork 21
PHP 7.4, 8.0 and 8.1 #27
base: master
Are you sure you want to change the base?
Conversation
Tagging @darylldoyle here as this pertains to internal tooling. I made this PR because I was wpsnapshots was failing when there was a union type in my codebase (php 8). I think wpsnapshots is using a docker image with PHP 7.4 |
@claytoncollie it seems that wp-local-docker doesn't use these images, it uses the ones over at https://github.com/10up/wp-php-fpm-dev. I'm actually unsure what purpose these images or even this repo serve. The https://github.com/10up/wp-php-fpm-dev repo already has images for everything up to 8.2; they're just not included in wp-local-docker. There's a PR to add support for them here, it's also possible to manually upgrade by updating the image in your # ...
phpfpm:
image: '10up/wp-php-fpm-dev:8.2-ubuntu'
# ... |
@darylldoyle My problem is not with wp local docker but with wpsnapshot. I have my project's container running PHP8 and am using union types on a function like this |
Thanks @claytoncollie, I see what you mean! I feel like https://github.com/10up/wpsnapshots/blob/cf28870fcf0fa3cc3f3ad07c6bce74c713bf587b/docker/Dockerfile#LL1C6-L1C17 should be updated to use @dustinrue or @tylercherpak do you have any thoughts around this? |
Thanks @claytoncollie. It seems that the wpsnapshots docker image is no longer sourced from this repo, see #20 for details. It's now built via a Github action from the https://github.com/10up/wpsnapshots repo. It looks like this file will need updating to use a more modern image. Likely one of the images in https://hub.docker.com/r/10up/wp-php-fpm-dev/ will be the best, since that has |
Adds support for PHP 7.4, 8.0 and 8.1
Closes #23 #24 #25
How to test the Change
I don't know how to test this change.
Changelog Entry
Credits
Props @claytoncollie
Checklist: