Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet filters: Don't remove spaces from value #2218

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

felipeelia
Copy link
Member

Description of the Change

As we don't remove spaces from the term name while generating the data-term-name attribute (see here), there is no point in removing it from the user inputted value.

Verification Process

  1. Create a category called "New York" and assign a post to it
  2. Create a facets widget with more than 15 terms, so filtering is enabled
  3. Type "New Y"
  4. See the term there

Applicable Issues

Closes #2217

Changelog Entry

  • Fix an error in facets filters where terms wouldn't match if the user types a space

Copy link
Contributor

@oscarssanchez oscarssanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oscarssanchez oscarssanchez merged commit 0940eec into develop May 27, 2021
@oscarssanchez oscarssanchez deleted the fix/issue-2217 branch May 27, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Facet filters don't work with term names containing spaces
2 participants