fix: Propagate EncoderBuilder
's setting of block_checksum
#52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when
BlockChecksum
was originally introduced, the setting onEncoderBuilder
never got passed down intoLZ4FPreferences
, resulting in errors like this. In this case, it's Go's lz4 library throwing the error:I confirmed that applying this patch locally fixes all of the
invalid block checksum
errors. I didn't have time to dig deeper into why this error was happening in the first place -- I would expect it to just result in the block checksum flag being turned on, and correct block checksums to be emitted, but somewhere along the line that appears to not be working correctly. Nevertheless, I believe this change fixes the ability to enable/disable block checksums correctly.