[TECH] Suppression du contexte certification/courses (PIX-13396). #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
AndreiaPena
force-pushed
the
pix-13396-remove-certification-course-context
branch
3 times, most recently
from
2333c61
to
b927980
Compare
|
Cette PR va dépendre de la PR #9374 car on modifie ici la route jury comment de course vers session-management |
pix-service-auto-merge
force-pushed
the
pix-13072-create-new-certification-results-context
branch
2 times, most recently
from
ca96ff3
to
0f8eeb0
Compare
Base automatically changed from
pix-13072-create-new-certification-results-context
to
dev
July 15, 2024 08:53
AndreiaPena
force-pushed
the
pix-13396-remove-certification-course-context
branch
from
b927980
to
3643a22
Compare
AndreiaPena
commented
Aug 1, 2024
api/lib/domain/usecases/index.js
Outdated
Comment on lines
17
to
18
| import { getNextChallengeForV2Certification } from '../../../src/certification/session-management/domain/usecases/get-next-challenge-for-v2-certification.js'; | ||
| import { getNextChallengeForV3Certification } from '../../../src/certification/session-management/domain/usecases/get-next-challenge-for-v3-certification.js'; |
There was a problem hiding this comment.
à supprimer de lib car plus utilisé
There was a problem hiding this comment.
Nom de nom @AndreiaPena t'imagines meme pas comment ca a ete chiant (cf # derniers commits) de supprimer ces lignes de lib 😭
Steph0
force-pushed
the
pix-13396-remove-certification-course-context
branch
3 times, most recently
from
fe43590
to
b9d55d9
Compare
Steph0
reviewed
Aug 2, 2024
| @@ -76,6 +90,11 @@ import { cpfReceiptsStorage } from '../../infrastructure/storage/cpf-receipts-st | |||
| const dependencies = { | |||
| ...sessionRepositories, | |||
| assessmentRepository, | |||
| assessmentResultRepository, | |||
| answerRepository, | |||
| sharedCompetenceMarkRepository, | |||
There was a problem hiding this comment.
ℹ️ ca va disparaitre dans la prochaine PR ce sharedCompetenceMarkRepository mais on a besoin de cet etat transitoire dans cette PR
Steph0
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Steph0
force-pushed
the
pix-13396-remove-certification-course-context
branch
from
b9d55d9
to
209358e
Compare
alexandrecoin
approved these changes
Aug 5, 2024
|
test fonctionnel :
|
matthieu-octo
approved these changes
Aug 5, 2024
Steph0
force-pushed
the
pix-13396-remove-certification-course-context
branch
from
209358e
to
5ed7339
Compare
…tory to session-management context
…e to session-management context
…izer to session-management context
…n-management context
…n-management context
…r to respect the context separation rules
Steph0
force-pushed
the
pix-13396-remove-certification-course-context
branch
from
5ed7339
to
a1471b9
Compare
Steph0
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
deleted the
pix-13396-remove-certification-course-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lors de notre premiere definition des contextes metier certif nous avons cree des contextes techniques.
Le contexte courses en fait parti et doit etre re-reparti dans les "vrais" nouveaux contextes pour pouvoir mourir en paix.
🤖 Proposition
🌈 Remarques
💯 Pour tester
Non reg sur