[BUGFIX] Ajouter les validations Joi sur les routes pour lesquelles il en manquait (PIX-13329) #9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
HEYGUL
reviewed
Jul 8, 2024
machestla
force-pushed
the
PIX-13329-fix-organization-member-in-admin
branch
from
2912b46
to
74e456e
Compare
machestla
changed the title
api/{organizationId}/memberships et api/admin/{organizationId}/memberships
machestla
force-pushed
the
PIX-13329-fix-organization-member-in-admin
branch
2 times, most recently
from
2658e41
to
707758d
Compare
HEYGUL
changed the title
HEYGUL
approved these changes
Jul 9, 2024
HEYGUL
force-pushed
the
PIX-13329-fix-organization-member-in-admin
branch
3 times, most recently
from
6aa6091
to
6fec28c
Compare
|
Prescription func & tech review ok 🐶 |
machestla
approved these changes
Jul 9, 2024
AndreiaPena
reviewed
Jul 9, 2024
AndreiaPena
force-pushed
the
PIX-13329-fix-organization-member-in-admin
branch
from
6fec28c
to
3c2769a
Compare
AndreiaPena
approved these changes
Jul 9, 2024
machestla
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
force-pushed
the
PIX-13329-fix-organization-member-in-admin
branch
from
3c2769a
to
de59774
Compare
pix-service-auto-merge
deleted the
PIX-13329-fix-organization-member-in-admin
branch
Faraopix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Suite à la modification du parsing et de validation des query parameters dans #9416, certaines routes se retrouvent avec une validation de query non-exhaustive.
Cela entraine une réponse
400 - Bad requestà des appels qui fonctionnaient bien auparavant.🤖 Proposition
Ajouter la liste exhaustive des query supportés par les routes.
Les routes impactées sont les suivantes :
/api/{organizationId}/memberships/api/admin/{organizationId}/memberships/api/admin/certification-centers🌈 Remarques
RAS
💯 Pour tester
Les tests au vert
tour fonctionnel sur toutes les routes impactées par cette PR et celles impactées par la PR nommée dan la partie Problème