Skip to content

[BUGFIX] Réparer l'affichage du nombre de tentatives de connexions restantes (PIX-18405) #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[BUGFIX] Réparer l'affichage du nombre de tentatives de connexions restantes (PIX-18405) #12621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/identity-access-management/domain/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class MissingOrInvalidCredentialsError extends DomainError {
this.meta = {};
this.meta.isLoginFailureWithUsername = meta?.isLoginFailureWithUsername ?? false;
if (meta?.remainingAttempts) {
this.meta = meta.remainingAttempts;
this.meta.remainingAttempts = meta.remainingAttempts;
}
}
}
Expand Down
88 changes: 64 additions & 24 deletions ...tests/identity-access-management/unit/application/http-error-mapper-configuration_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,96 +40,136 @@ describe('Unit | Identity Access Management | Application | HttpErrorMapperConfi

context('when mapping "DifferentExternalIdentifierError"', function () {
it('returns an ConflictError Http Error', function () {
//given
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === DifferentExternalIdentifierError.name,
);

//when
// when
const error = httpErrorMapper.httpErrorFn(new DifferentExternalIdentifierError());

//then
// then
expect(error).to.be.instanceOf(HttpErrors.ConflictError);
});
});

context('when mapping "MissingOrInvalidCredentialsError"', function () {
it('returns an UnauthorizedError Http Error', function () {
//given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === MissingOrInvalidCredentialsError.name,
);
context('when isLoginFailureWithUsername is true', function () {
it('returns a UnauthorizedError with isLoginFailureWithUsername set to true', function () {
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === MissingOrInvalidCredentialsError.name,
);

// when
const error = httpErrorMapper.httpErrorFn(
new MissingOrInvalidCredentialsError({ isLoginFailureWithUsername: true }),
);

// then
expect(error).to.be.instanceOf(HttpErrors.UnauthorizedError);
expect(error.meta.isLoginFailureWithUsername).to.be.true;
});
});

//when
const error = httpErrorMapper.httpErrorFn(new MissingOrInvalidCredentialsError());
context('when isLoginFailureWithUsername is false', function () {
it('returns a UnauthorizedError with isLoginFailureWithUsername set to false', function () {
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === MissingOrInvalidCredentialsError.name,
);

// when
const error = httpErrorMapper.httpErrorFn(
new MissingOrInvalidCredentialsError({ isLoginFailureWithUsername: false }),
);

// then
expect(error).to.be.instanceOf(HttpErrors.UnauthorizedError);
expect(error.meta.isLoginFailureWithUsername).to.be.false;
});
});

//then
expect(error).to.be.instanceOf(HttpErrors.UnauthorizedError);
context('when remainingAttempts is provided', function () {
it('returns a UnauthorizedError with remainingAttempts set', function () {
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === MissingOrInvalidCredentialsError.name,
);
const remainingAttempts = 3;

// when
const error = httpErrorMapper.httpErrorFn(new MissingOrInvalidCredentialsError({ remainingAttempts }));

// then
expect(error).to.be.instanceOf(HttpErrors.UnauthorizedError);
expect(error.meta.remainingAttempts).to.equal(remainingAttempts);
});
});
});

context('when mapping "MissingUserAccountError"', function () {
it('returns an BadRequestError Http Error', function () {
//given
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === MissingUserAccountError.name,
);

//when
// when
const error = httpErrorMapper.httpErrorFn(new MissingUserAccountError());

//then
// then
expect(error).to.be.instanceOf(HttpErrors.BadRequestError);
});
});

context('when mapping "PasswordResetDemandNotFoundError"', function () {
it('returns a NotFoundError Http Error', function () {
//given
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === PasswordResetDemandNotFoundError.name,
);
const message = 'Test message error';

//when
// when
const error = httpErrorMapper.httpErrorFn(new PasswordResetDemandNotFoundError(message));

//then
// then
expect(error).to.be.instanceOf(HttpErrors.NotFoundError);
expect(error.message).to.equal(message);
});
});

context('when mapping "UserCantBeCreatedError"', function () {
it('returns an UnauthorizedError Http Error', function () {
//given
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === UserCantBeCreatedError.name,
);
const message = 'Test message error';

//when
// when
const error = httpErrorMapper.httpErrorFn(new UserCantBeCreatedError(message));

//then
// then
expect(error).to.be.instanceOf(HttpErrors.UnauthorizedError);
expect(error.message).to.equal(message);
});
});

context('when mapping "UserShouldChangePasswordError"', function () {
it('returns an PasswordShouldChangeError Http Error', function () {
//given
// given
const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
(httpErrorMapper) => httpErrorMapper.name === UserShouldChangePasswordError.name,
);
const message = 'Test message error';
const meta = 'Test meta';

//when
// when
const error = httpErrorMapper.httpErrorFn(new UserShouldChangePasswordError(message, meta));

//then
// then
expect(error).to.be.instanceOf(HttpErrors.PasswordShouldChangeError);
expect(error.message).to.equal(message);
expect(error.meta).to.equal(meta);
Expand Down