-
Notifications
You must be signed in to change notification settings - Fork 58
[FEATURE] Ajouter la suppression de participations / assessment / badge / trainings lors de la suppression d'un import SUP (PIX-18074) #12514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-18074/add-campaign-participation-deletion-on-learner-import-sup
Jun 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
8c3b31a to
2df5a4d
Compare
2df5a4d to
598bfc4
Compare
xav-car
commented
Jun 12, 2025
...ption/learner-management/application/jobs/import-sup-organization-learners-job-controller.js
Show resolved
Hide resolved
ada135b to
2eddd07
Compare
api/src/prescription/learner-management/domain/usecases/get-active-organization-learner-ids.js
Outdated
Show resolved
Hide resolved
VincentHardouin
approved these changes
Jun 13, 2025
...nagement/integration/infrastructure/repositories/sup-organization-learner-repository_test.js
Outdated
Show resolved
Hide resolved
...nagement/integration/infrastructure/repositories/sup-organization-learner-repository_test.js
Outdated
Show resolved
Hide resolved
...nagement/integration/infrastructure/repositories/sup-organization-learner-repository_test.js
Outdated
Show resolved
Hide resolved
...iption/learner-management/infrastructure/repositories/sup-organization-learner-repository.js
Show resolved
Hide resolved
...agement/integration/application/jobs/import-sup-organization-learners-job-controller_test.js
Show resolved
Hide resolved
...ner-management/unit/application/jobs/import-sup-organization-learners-job-controller_test.js
Outdated
Show resolved
Hide resolved
...agement/integration/application/jobs/import-sup-organization-learners-job-controller_test.js
Outdated
Show resolved
Hide resolved
4ae8906 to
de29b1e
Compare
de29b1e to
c4af4fc
Compare
pix-service
pushed a commit
that referenced
this pull request
Jun 17, 2025
# [5.136.0](v5.135.0...v5.136.0) (2025-06-17) ### 🚀 Amélioration - [#12514](#12514) Ajouter la suppression de participations / assessment / badge / trainings lors de la suppression d'un import SUP (PIX-18074) - [#12513](#12513) Faire disparaître les élements du toaster automatiquement lors du changement de page sur Pix Admin (PIX-18169). - [#12387](#12387) Nouveaux messages d'erreur lors d'une tentative de connexion (PIX-17949) - [#12554](#12554) Support des web-components Vue >=3.5.15 (PIX-18219) ### 🐛 Correction - [#12547](#12547) Éviter d'appeller le LLM en mode preview (PIX-18295) ### 🏗️ Tech - [#12555](#12555) Suppression d'un script inutilisé. - [#12542](#12542) Suppression du service Campaign Media Compliance (PIX-18206). ### ⬆️ Montée de version - [#12551](#12551) Update dependency @1024pix/epreuves-components to ^0.4.0 (junior) - [#12552](#12552) Update dependency @1024pix/epreuves-components to ^0.4.0 (mon-pix) - [#12553](#12553) Update dependency ember-source to ~6.5.0 (junior) - [#12539](#12539) Update slackapi/slack-github-action action to v2.1.0 (workflows)
Contributor
|
🎉 This PR is included in version 5.136.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Func Review OK
PO validated functionally the PR
released
🚀 Ready to Merge
team-prescription
Tech Review OK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔆 Problème
Lorsqu'on fait un import sur une orga SUP pour remplacer des prescrits, on supprime les anciens prescrits non présents dans le fichier avant d'ajouter / modifier ceux du fichier. mais les prescrits ne sont jamais anonymisés.
⛱️ Proposition
Modifier le job d'import du SUP pour qu'il utilise le usecase de suppression des prescrits car il supporte le feature flag (et on ré-utilise du code et c'est beau)
🌊 Remarques
En passant par le usecase de suppression de learner, on modifie aussi le
updatedAtsur l'organizationLearner supprimé (ce qui n'était pas fait avant)🏄 Pour tester
Avec le Flag d'anonymisation à
falseAvec le Flag d'anonymisation à
true