refactor(api): introduce refreshLearningContentCache usecase

1024pix · Jul 9, 2024 · fcccb95 · fcccb95
1 parent 513a295
commit fcccb95
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 43 deletions.
diff --git a/api/lib/application/cache/cache-controller.js b/api/lib/application/cache/cache-controller.js
@@ -1,12 +1,10 @@
 import _ from 'lodash';
 
-import { knex } from '../../../db/knex-database-connection.js';
+import { sharedUsecases as usecases } from '../../../src/shared/domain/usecases/index.js';
 import * as LearningContentDatasources from '../../../src/shared/infrastructure/datasources/learning-content/index.js';
-import { LcmsRefreshCacheJob } from '../../infrastructure/jobs/lcms/LcmsRefreshCacheJob.js';
 
 const refreshCacheEntries = async function (_, h) {
-  const refreshJob = new LcmsRefreshCacheJob(knex);
-  await refreshJob.schedule();
+  await usecases.refreshLearningContentCache();
   return h.response({}).code(202);
 };
 

diff --git a/api/src/shared/domain/usecases/index.js b/api/src/shared/domain/usecases/index.js
@@ -1,6 +1,8 @@
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
+import { knex } from '../../../../db/knex-database-connection.js';
+import { LcmsRefreshCacheJob } from '../../../../lib/infrastructure/jobs/lcms/LcmsRefreshCacheJob.js';
 import * as complementaryCertificationBadgeRepository from '../../../certification/complementary-certification/infrastructure/repositories/complementary-certification-badge-repository.js';
 import * as badgeRepository from '../../../evaluation/infrastructure/repositories/badge-repository.js';
 import { injectDependencies } from '../../../shared/infrastructure/utils/dependency-injection.js';
@@ -15,6 +17,7 @@ const usecasesWithoutInjectedDependencies = {
 const dependencies = {
   complementaryCertificationBadgeRepository,
   badgeRepository,
+  lcmsRefreshCacheJob: new LcmsRefreshCacheJob(knex),
 };
 
 const sharedUsecases = injectDependencies(usecasesWithoutInjectedDependencies, dependencies);

diff --git a/api/src/shared/domain/usecases/refresh-learning-content-cache.js b/api/src/shared/domain/usecases/refresh-learning-content-cache.js
@@ -0,0 +1,4 @@
+const refreshLearningContentCache = async function ({ lcmsRefreshCacheJob }) {
+  await lcmsRefreshCacheJob.schedule();
+};
+export { refreshLearningContentCache };
diff --git a/api/tests/shared/unit/domain/usecases/refresh-learning-content-cache_test.js b/api/tests/shared/unit/domain/usecases/refresh-learning-content-cache_test.js
@@ -0,0 +1,15 @@
+import { refreshLearningContentCache } from '../../../../../src/shared/domain/usecases/refresh-learning-content-cache.js';
+import { expect, sinon } from '../../../../test-helper.js';
+
+describe('Unit | Domain | Usecases | Refresh Learning Content Cache', function () {
+  it('should use repository to schedule reefresh job', async function () {
+    // given
+    const lcmsRefreshCacheJob = { schedule: sinon.stub() };
+
+    // when
+    await refreshLearningContentCache({ lcmsRefreshCacheJob });
+
+    // then
+    expect(lcmsRefreshCacheJob.schedule).to.have.been.calledOnce;
+  });
+});
diff --git a/api/tests/unit/application/cache/cache-controller_test.js b/api/tests/unit/application/cache/cache-controller_test.js
@@ -1,6 +1,6 @@
 import { cacheController } from '../../../../lib/application/cache/cache-controller.js';
+import { sharedUsecases as usecases } from '../../../../src/shared/domain/usecases/index.js';
 import * as learningContentDatasources from '../../../../src/shared/infrastructure/datasources/learning-content/index.js';
-import { logger } from '../../../../src/shared/infrastructure/utils/logger.js';
 import { expect, hFake, sinon } from '../../../test-helper.js';
 
 describe('Unit | Controller | cache-controller', function () {
@@ -79,53 +79,18 @@ describe('Unit | Controller | cache-controller', function () {
   });
 
   describe('#refreshCacheEntries', function () {
-    const request = {};
-    let learningContentDatasourceStub;
-
-    beforeEach(function () {
-      learningContentDatasourceStub = { refreshLearningContentCacheRecords: sinon.stub() };
-    });
-
     context('nominal case', function () {
       it('should reply with http status 202', async function () {
         // given
-        const numberOfDeletedKeys = 0;
-        learningContentDatasourceStub.refreshLearningContentCacheRecords.resolves(numberOfDeletedKeys);
-
-        // when
-        const response = await cacheController.refreshCacheEntries(request, hFake, {
-          learningContentDatasource: learningContentDatasourceStub,
-        });
-
-        // then
-        expect(learningContentDatasourceStub.refreshLearningContentCacheRecords).to.have.been.calledOnce;
-        expect(response.statusCode).to.equal(202);
-      });
-    });
-
-    context('error case', function () {
-      let response;
-
-      beforeEach(async function () {
-        // given
-        sinon.stub(logger, 'error');
-        learningContentDatasourceStub.refreshLearningContentCacheRecords.rejects();
+        sinon.stub(usecases, 'refreshLearningContentCache').resolves();
 
         // when
-        response = await cacheController.refreshCacheEntries(request, hFake, {
-          learningContentDatasource: learningContentDatasourceStub,
-        });
-      });
+        const response = await cacheController.refreshCacheEntries({}, hFake);
 
-      it('should reply with http status 202', async function () {
         // then
+        expect(usecases.refreshLearningContentCache).to.have.been.calledOnce;
         expect(response.statusCode).to.equal(202);
       });
-
-      it('should call log errors', async function () {
-        // then
-        expect(logger.error).to.have.been.calledOnce;
-      });
     });
   });
 });