Skip to content

Commit

Permalink
fix: onClickOverlay now closes the modal properly
Browse files Browse the repository at this point in the history
  • Loading branch information
sbedeau authored Feb 24, 2021
1 parent 3a33bc6 commit 0ea4e53
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<PixModal @containerClass="join-error-modal">
<PixModal @containerClass="join-error-modal" @onClickOverlay={{@closeModal}}>
<div class="join-error-modal__header">
<div class="join-error-modal-header__title">
<h1 class="join-error-modal-header-title__text">{{t 'pages.join.sco.login-information-title'}}</h1>
Expand Down
2 changes: 1 addition & 1 deletion mon-pix/app/templates/components/comparison-window.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<PixModal @class="comparison-window-modal">
<PixModal @class="comparison-window-modal" @onClickOverlay={{@closeComparisonWindow}}>

<button type="button" class="pix-modal__close-link" aria-label={{t "common.actions.close"}} {{on "click" @closeComparisonWindow}}>
<span>{{t "common.actions.close"}}</span>
Expand Down
2 changes: 1 addition & 1 deletion mon-pix/app/templates/components/scorecard-details.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
{{/if}}
</div>
{{#if this.showResetModal}}
<PixModal @containerClass="scorecard-details__reset-modal pix-modal-dialog--wide">
<PixModal @containerClass="scorecard-details__reset-modal pix-modal-dialog--wide" @onClickOverlay={{this.closeModal}}>
<button class="pix-modal__close-link" type="button" aria-label="{{t 'common.actions.close'}}" {{on 'click' this.closeModal}}>
<span>{{t 'common.actions.close'}}</span>
<FaIcon @icon="times-circle" class="logged-user-menu__icon"></FaIcon>
Expand Down

0 comments on commit 0ea4e53

Please sign in to comment.