[codex] Pass pinned bridge ref into Manual Build - #517
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 44 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds two new workflow inputs, ChangesBuild Workflow Input Wiring
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
coderabbitai
Bot
added
area:native-companion
evaOS review status: stale headPR: #517 - [codex] Pass pinned bridge ref into Manual Build evaOS review stopped because this queued head is no longer the live PR head. Automation note: agents should wait for this comment to reach PR URL: #517 Details: Superseded by a newer PR head. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-manual.yml:
- Around line 33-45: Add workflow/job-level concurrency controls to the manual
build workflow to prevent overlapping dispatches from racing on shared aioncore
run artifacts. Update the workflow definition in build-manual.yml by adding a
concurrency group keyed off the workflow and branch/ref, and enable
cancel-in-progress where appropriate. Make sure the concurrency setting is
applied at the top-level workflow or the relevant job so repeated manual runs
serialize correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 57a647e4-7919-4f48-a417-52eb1df5f7a3
📒 Files selected for processing (2)
.github/workflows/_build-reusable.yml.github/workflows/build-manual.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: Thin App Smoke (macos-arm64)
- GitHub Check: Unit Tests (macos-14)
- GitHub Check: Coverage Test
🧰 Additional context used
🪛 zizmor (1.26.1)
.github/workflows/build-manual.yml
[warning] 7-45: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting
(concurrency-limits)
🔇 Additional comments (4)
.github/workflows/_build-reusable.yml (3)
26-33: New workflow_call inputs look correct.Types, descriptions and defaults are consistent with how they're consumed downstream (
AIONUI_BACKEND_RUN_ID/AIONUI_MANAGED_RESOURCES_BUNDLE, validated inscripts/prepare-aioncore.js).
322-323: LGTM!
463-464: 🩺 Stability & AvailabilitymacOS-only bridge prep makes this env wiring sufficient.
scripts/build-with-builder.jsgatesscripts/prepareEvaosDesktopBridgeResource.jsbehind anisMacBuildcheck, so Windows/Linux packaging won’t reach the strict-ref path.> Likely an incorrect or invalid review comment..github/workflows/build-manual.yml (1)
98-99: LGTM!
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 714dc351b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
evaOS review status: closed or merged before reviewPR: #517 - [codex] Pass pinned bridge ref into Manual Build evaOS review stopped because the PR closed or merged before this queued head could be reviewed. Automation note: agents should wait for this comment to reach PR URL: #517 Details: state=closed |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fb0a0ab08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CSC_NAME: ${{ secrets.IDENTITY }} | ||
| CSC_IDENTITY_AUTO_DISCOVERY: false | ||
| EVAOS_DESKTOP_BRIDGE_REQUIRE_REAL: 'true' | ||
| EVAOS_DESKTOP_BRIDGE_SOURCE_REF: ${{ vars.EVAOS_DESKTOP_BRIDGE_SOURCE_REF }} |
There was a problem hiding this comment.
When Manual Build checks out an older/beta branch via ref: inputs.branch, the scripts/prepareEvaosDesktopBridgeResource.js that runs is from that checked-out branch, not necessarily the current one with the hard-coded pinned default. If the repo/org variable EVAOS_DESKTOP_BRIDGE_SOURCE_REF is unset, this line exports an empty value, so strict macOS builds can still fall back to that branch's mutable/default ref and fail the pinned-ref check. Add a literal approved SHA fallback here, or make the ref a required manual input, so the default-branch workflow is self-contained for older build refs.
Useful? React with 👍 / 👎.
1 participant
Summary
no-acpso RC artifacts keep the intended smaller profileEVAOS_DESKTOP_BRIDGE_SOURCE_REFand source token into the macOS electron-builder step so strict release builds do not fall back tomainRoot Cause
Manual Build runs workflow files from
mainwhile checking out the requested beta SHA. The default-branch workflow did not pass the pinned bridge ref intoscripts/prepareEvaosDesktopBridgeResource.js, so run28578700265failed before packaging withRelease builds require a pinned evaos-desktop-bridge source ref.Validation
git diff --checkruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "ok #{f}" }' .github/workflows/build-manual.yml .github/workflows/_build-reusable.yml\n\nRefs P0 Approve/Hold: 2.1.23 public distribution and live download/install proof #361, Sprint: Mac Control Contract Unification + Matt-Style Reconciler #480, P0: Broker runtime surface repair: proxy modules must not depend on Mac connector #500\nSummary by CodeRabbit
no-acpandfullbundle modes.