Skip to content

chore: use repo bridge ref for Workbench smoke fallback - #473

Merged
100yenadmin merged 1 commit into
evaos/beta-rc-20260612from
codex/bridge-ref-fallback-473
Jun 28, 2026
Merged

chore: use repo bridge ref for Workbench smoke fallback#473
100yenadmin merged 1 commit into
evaos/beta-rc-20260612from
codex/bridge-ref-fallback-473

Conversation

@100yenadmin

@100yenadmin 100yenadmin commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • make Workbench Functional Smoke default to the EVAOS_DESKTOP_BRIDGE_SOURCE_REF repo variable when bridge_ref is omitted
  • remove the stale hardcoded bridge SHA that caused run 28315669345 to false-green against 207f652...

Validation

Summary by CodeRabbit

  • Chores
    • Updated the smoke test trigger to use a configurable default when no reference is provided.
    • Removed the fixed default reference so runs can fall back to the repository setting automatically.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 473ab875-216f-4b78-81c5-43cd803fabf0

📥 Commits

Reviewing files that changed from the base of the PR and between c5669e1 and 782d81d.

📒 Files selected for processing (1)
  • .github/workflows/workbench-functional-smoke.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: Coverage Test
  • GitHub Check: Build Test (macos-arm64)
  • GitHub Check: Unit Tests (macos-14)
🔇 Additional comments (1)
.github/workflows/workbench-functional-smoke.yml (1)

20-22: LGTM!

Also applies to: 39-39


📝 Walkthrough

Walkthrough

The workbench-functional-smoke workflow's bridge_ref input default is changed from a hardcoded commit hash to an empty string. WORKBENCH_SMOKE_BRIDGE_REF now resolves via inputs.bridge_ref || vars.EVAOS_DESKTOP_BRIDGE_SOURCE_REF.

Changes

Bridge ref repo-variable fallback

Layer / File(s) Summary
bridge_ref input default and env fallback
.github/workflows/workbench-functional-smoke.yml
bridge_ref default changed from hardcoded commit hash to ''; WORKBENCH_SMOKE_BRIDGE_REF now falls back to vars.EVAOS_DESKTOP_BRIDGE_SOURCE_REF when input is empty.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • 100yenadmin/evaOS-GUI#470: Directly modifies the same bridge_ref input and WORKBENCH_SMOKE_BRIDGE_REF wiring in the same workflow file.

Suggested labels

area:native-companion, kind:integration

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the workflow fallback change.
Description check ✅ Passed The description covers the change summary and validation, though it omits several template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/bridge-ref-fallback-473

Comment @coderabbitai help to get the list of available commands.

@100yenadmin

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot added area:native-companion Native macOS companion boundary kind:integration Integration implementation issue labels Jun 28, 2026
@100yenadmin
100yenadmin merged commit 7462113 into evaos/beta-rc-20260612 Jun 28, 2026
18 of 21 checks passed
@100yenadmin
100yenadmin deleted the codex/bridge-ref-fallback-473 branch June 28, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:native-companion Native macOS companion boundary kind:integration Integration implementation issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant