Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
1 task done
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Owner
Author
|
Superseded by vllm-project#459, now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental review: Files changed.
Direct dependency and ancestor review: #4 → #3 → #1. Baseline: cleaned #4 head
2d04ab6a66e7b6f223d935bff3e368d16a97cdda. This fork PR shows only this layer.Adapt the Ouro recipe to the public rollout/update contract in vllm-rlt#78, add physical HF↔Megatron parameter conversion and score training tokens at their actual decode depth after full-depth prefill. CUDA graphs use the engine's graph settings; checkpoints preserve the schedule and data contract.
Minhao proposed aligning the wrapper with his engine contract. The Thor replay checks established full-four-loop prefill and actual-depth decoding for K=2/3/4, early stops and delayed stops. Seed handling was corrected. The public implementation maps
log_probstologprobsand uses engine-level probability processing. His exact upstream PR1 was not available; formal compatibility acceptance remains pending.Full Ouro-1.4B, five alternating warmed rollout pairs:
These workload-specific rollout gains do not establish complete-step acceleration. A100 measurements had shared-resource contention and host-staged transfers (
UCX_TLS=tcp,cuda_copy).This historical fork layer is consolidated in upstream #459. Added tests, logs, reports and coordination files were removed; measurements remain in this description. Completed-task model files were cleaned up. Full-model convergence and broader topology coverage remain outstanding.