Conversation
Codecov Report❌ Patch coverage is
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
f8a0319 to
bcffecf
Compare
HerbertJordan
left a comment
There was a problem hiding this comment.
I checked that:
- the PR is the merge of the cherry-picked commits
- the referenced Tosca version is correct and the Tosca version contains valid changes
- the referenced go-ethereum version is correct and it contains valid changes
@wsodsong Before releasing, a full release test, in particular covering the referenced go-ethereum version, must be conducted.
HerbertJordan
left a comment
There was a problem hiding this comment.
I undo my approval as an issue in the go-ethereum fork has been found. A unit test has been failing.
I undo my approval as an issue in the go-ethereum fork has been found. A unit test has been failing.
HerbertJordan
left a comment
There was a problem hiding this comment.
There seems to be a low-frequency flaky test in go-etheruem:
--- FAIL: TestTransactionRollbackBehavior (11.19s)
rollback_test.go:58: all post-rollback transactions were not included
FAIL
FAIL github.com/ethereum/go-ethereum/ethclient/simulated 13.457s
It could not be reproduced and seems to be low-frequent enough to be acceptable for release testing.
This PR updates the geth dependency version of the release branch to 1.16.9. The main branch has been updates 3 times, therefore 3 separate commits have been cherry-picked.
A test which has already been part of a previous release had to be updated to stay compatible with the stateDB interface changes.