Skip to content

Geth dependency upgrade release 2.1.6#666

Merged
wsodsong merged 6 commits intov2.1from
simon/geth-v2.1.6
Feb 25, 2026
Merged

Geth dependency upgrade release 2.1.6#666
wsodsong merged 6 commits intov2.1from
simon/geth-v2.1.6

Conversation

@simonlechner
Copy link
Copy Markdown
Contributor

This PR updates the geth dependency version of the release branch to 1.16.9. The main branch has been updates 3 times, therefore 3 separate commits have been cherry-picked.
A test which has already been part of a previous release had to be updated to stay compatible with the stateDB interface changes.

Comment thread go.mod
Comment thread go.mod Outdated
Comment thread go.mod Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
opera/contracts/evmwriter/evm_writer.go 33.33% 2 Missing ⚠️
evmcore/tx_pool.go 66.66% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
ethapi/api.go 45.34% <100.00%> (ø)
ethapi/transaction_args.go 87.01% <100.00%> (ø)
evmcore/state_processor.go 97.08% <100.00%> (ø)
evmcore/tx_list.go 95.03% <100.00%> (ø)
gossip/evmstore/carmen.go 78.60% <100.00%> (+0.21%) ⬆️
gossip/evmstore/statedb_logger.go 44.00% <100.00%> (ø)
gossip/gasprice/reactive.go 91.04% <100.00%> (+0.06%) ⬆️
integration/makegenesis/genesis.go 82.95% <100.00%> (ø)
opera/vm_config.go 90.90% <100.00%> (ø)
utils/int.go 77.77% <100.00%> (+22.22%) ⬆️
... and 2 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

HerbertJordan
HerbertJordan previously approved these changes Feb 24, 2026
Copy link
Copy Markdown
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that:

  • the PR is the merge of the cherry-picked commits
  • the referenced Tosca version is correct and the Tosca version contains valid changes
  • the referenced go-ethereum version is correct and it contains valid changes

@wsodsong Before releasing, a full release test, in particular covering the referenced go-ethereum version, must be conducted.

Copy link
Copy Markdown
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I undo my approval as an issue in the go-ethereum fork has been found. A unit test has been failing.

@HerbertJordan HerbertJordan self-requested a review February 24, 2026 14:04
@HerbertJordan HerbertJordan dismissed their stale review February 24, 2026 14:04

I undo my approval as an issue in the go-ethereum fork has been found. A unit test has been failing.

Copy link
Copy Markdown
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a low-frequency flaky test in go-etheruem:

--- FAIL: TestTransactionRollbackBehavior (11.19s)
    rollback_test.go:58: all post-rollback transactions were not included
FAIL
FAIL	github.com/ethereum/go-ethereum/ethclient/simulated	13.457s

It could not be reproduced and seems to be low-frequent enough to be acceptable for release testing.

@wsodsong wsodsong merged commit 56146a6 into v2.1 Feb 25, 2026
3 checks passed
@simonlechner simonlechner deleted the simon/geth-v2.1.6 branch February 25, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants