-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add crate sdk-prover
, and add functionality to get self_prog_id
within
#1701
Open
codeblooded1729
wants to merge
11
commits into
main
Choose a base branch
from
kapil/prog_id_bytes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
codeblooded1729
commented
May 14, 2024
Comment on lines
+7
to
+12
cd examples/token && \ | ||
cargo build --bin tokenbin --release && \ | ||
cargo run --release \ | ||
--features="native" \ | ||
--bin token-native \ | ||
--target "$(rustc --verbose --version | grep host | awk '{ print $2; }')" && | ||
cargo build --bin tokenbin --release | ||
--target "$(rustc --verbose --version | grep host | awk '{ print $2; }')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to build the ELF first, since we require their ProgramIdenitifier
in native execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces the crate
sdk-prover
. The need for this crate arose from native programs requiring access to theself_prog_id
of their guest programs.sdk
was insufficient in this regard, since it was hard to have it depend oncircuits
andrunner
(since they themselves depend onsdk
). Also, a need for a version ofsdk
was felt, which would have access to proving system (in the case ofself_prog_id
, we need to have a dry run ofProgram
, and tools to compute merkle caps of certain tables). Hence the crate, and its first module,prog_id_bytes
.Since an
impl
ofProgramidentifier
, which createsself_prog_id
out of its ELF, would create a cyclic dependency, we implement the above for a similar structProgId
insidesdk-prover
instead, and further implement traitFrom<ProgId> for ProgramIdentifier
. Now, a native program, for say token example, can getProgramIdentifier
of its guest program by the following line of codeThis PR also introduces a new CLI command
self-prog-id
which dumps the the same for givenELF
. We also update theexample_prog_id
for core examples, with their correct version.First part of tracking issue #1703