Add Support for Interface types in SDL-Transformation and generade ad… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2021 22:22
…ditional @extends directives in extending Interfaces and Type
johgoe
reviewed
Oct 26, 2021
| @@ -89,4 +89,6 @@ typings/ | |||
| # DynamoDB Local files | |||
| .dynamodb/ | |||
|
|
|||
| dist/ | |||
There was a problem hiding this comment.
@mwildt Is it required to remove git ignore for folder dist? You also added a lot of new files in oder dist/* which shouldn't belong to this pull request.
|
In general I tested to extend a GraphQLInterface type for federation succesful. I hope the changes in 78567ae in the files
will be merged to this package to make it available in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying around with this package, i found that it is not possible to inject federation information for interface-types. I made some minor changes in the transform-sdl file to support ferderation of interface types.
I also added generation of @extends directives.
Looking forward to your feedback...