This repository was archived by the owner on Oct 11, 2024. It is now read-only.

blockwatch/core: Fix Kovan incorrect block hash bug#181

Merged

fabioberger merged 11 commits intomasterfrom

fix/kovanBlockHashIssue

Jun 19, 2019

Commits on Jun 19, 2019

Use RPC client for eth_getBlockByNumber calls to fix bug where go-ethereum isn't properly computing block hashes for Kovan
fabioberger
committed
Log BlockWatcher errors
fabioberger
committed
Close the Errors chan when stopping to BlockWatcher and exit the go routine when it's closed
fabioberger
committed
Avoid calling close on Errors channel twice
fabioberger
committed
Add a comment about why we use a raw RPC call for HeaderByNumber
fabioberger
committed
Remove superfluous check
fabioberger
committed
Explicitly map params

fabioberger
and
albrow
authored
Update ethereum/blockwatch/client.go

fabioberger
and
albrow
authored
Make stopPolling unexported since it should never be called directly
fabioberger
committed
Merge branch 'fix/kovanBlockHashIssue' of github.com:0xProject/0x-mesh into fix/kovanBlockHashIssue
fabioberger
committed
Call Stop instead of stopPolling at end of test
fabioberger
committed