Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emit instruction and host event handler #1119

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add emit instruction and host event handler #1119

merged 1 commit into from
Oct 24, 2023

Conversation

frisitano
Copy link
Contributor

This PR introduces the Event decorated and associated emit instruction as describe in #1105.

@frisitano frisitano changed the title Add host event handler Add emit instruction and host event handler Oct 23, 2023
@frisitano frisitano requested a review from bobbinth October 23, 2023 07:45
@frisitano frisitano force-pushed the frisitano/host-event-handler branch 2 times, most recently from a9ef6bb to 3f9da8e Compare October 23, 2023 08:20
bobbinth
bobbinth approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! We should do two other things:

  • Add description of the of events to user docs (maybe as another section under "Miden Assembly" - though, not sure if that's the best place).
  • Add an entry to the changelog.

@frisitano frisitano force-pushed the frisitano/host-event-handler branch from 3f9da8e to c5e3cb7 Compare October 24, 2023 06:24
@frisitano frisitano force-pushed the frisitano/host-event-handler branch from c5e3cb7 to 18fdeda Compare October 24, 2023 09:44
@frisitano frisitano merged commit ef9a121 into next Oct 24, 2023
@frisitano frisitano deleted the frisitano/host-event-handler branch October 24, 2023 09:55
@frisitano frisitano mentioned this pull request Oct 24, 2023
Closed
@bobbinth bobbinth mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frisitano @bobbinth