Implement TSMT leaf insertion into advice map #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
force-pushed
the
bobbin-tsmt-bugfix
branch
from
8188cf6 to
49302ec
Compare
Al-Kindi-0
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Looks great, thank you @bobbinth !
Just a minor nit from my side.
frisitano
approved these changes
Aug 15, 2023
bobbinth
force-pushed
the
bobbin-tsmt-bugfix
branch
from
49302ec to
7d70762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new advice injector (
adv.insert_hperm) which hashes the values at the top of the stack and uses the result to insert a new entry into the advice map. This advice injector is then used in the TSMT insert procedures to insert pre-images of newly created leaves into the advice map.Fixes #1041.