-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(air): migrate range checker bus to LogUp #1027
Conversation
5674e5f
to
e49f1ec
Compare
Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! I left a few small blocking comments inline - some of them can be left for future PRs.
Re moving padding to the end - yes, let's leave it for a future PR. We can also combine this with one other potential optimization idea i left inline.
Oh - one other thing: let's update the changelog to include this change. |
This PR addresses #982 and #299 (no longer needed), simplifying the range checker to require only 2 main trace columns and a single auxiliary trace column.