Stack outputs constructor error handling #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Jul 18, 2023
bobbinth
reviewed
Jul 18, 2023
bobbinth
reviewed
Jul 18, 2023
frisitano
force-pushed
the
frisitano-stack-outputs-constructor
branch
from
3c990d3 to
888c417
Compare
frisitano
force-pushed
the
frisitano-stack-outputs-constructor
branch
from
888c417 to
a83d9c5
Compare
bobbinth
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces error handling in the
StackOutputsconstructor. If the number of elements is less then 16 then an error is returned.I have left some
TODOinline around error handling related tooverflow_addrsand error handling in the processor. Some discussion on these points would be appreciated.closes: #1007