feat(block-producer): instrument mempool #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tracing` 0.1.41 added support for target = const` which will improve our instrumentation.
Mirko-von-Leipzig
force-pushed
the
mirko/feat/instrument-mempool
branch
from
1013cb8 to
077d3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tracing instrumentation to the mempool.
In addition, this PR also bumps
tracingto v0.14 which now allows using constants for instrument targets. Before this we've had the unfortunate situation of usingtarget = COMPONENTwhen emitting events, but having to manually settarget = miden-node-<xxx>when using the#[instrument]macro. This PR fixes this; though I think our behaviour here could be improved.Blocked by #577 as it refactors batch ID, and by #574 which added instrumentation which will require a minor tweak or two in this PR.
Closes a task in #519