feat: Return code for FPI #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 22, 2024
bobbinth
reviewed
Oct 22, 2024
crates/store/src/state.rs
Outdated
| @@ -691,7 +693,7 @@ impl State { | |||
| let inner_state = self.inner.read().await; | |||
|
|
|||
| let state_headers = if !include_headers { | |||
| BTreeMap::<AccountId, AccountStateHeader>::default() | |||
| BTreeMap::<u64, AccountStateHeader>::new() | |||
There was a problem hiding this comment.
Why was this change necessary?
There was a problem hiding this comment.
It wasn't, I thought I was rolling it back correctly but I wasn't (AccountId here is a newtype for u64)
bobbinth
approved these changes
Oct 22, 2024
Comment on lines
+138
to
+142
| // Account code commitments corresponding to the last-known `AccountCode` for requested | ||
| // accounts. Responses will include only the ones that are not known to the caller. | ||
| repeated digest.Digest code_commitments = 2; | ||
| // Optional flag to include header in the response. `false` by default. | ||
| optional bool include_headers = 2; | ||
| optional bool include_headers = 3; |
There was a problem hiding this comment.
nit: I would move include_headers above code_commitments.
Also, we should update comments to make it clear that account code only is included if include_headers is true, and also that it is not associated with a specific account ID (i.e., we check code roots against all accounts).
bobbinth
reviewed
Oct 23, 2024
crates/store/src/server/api.rs
Outdated
| @@ -485,13 +485,25 @@ impl api_server::Api for StoreApi { | |||
| request: Request<GetAccountProofsRequest>, | |||
| ) -> Result<Response<GetAccountProofsResponse>, Status> { | |||
| let request = request.into_inner(); | |||
| if request.account_ids.len() >= request.code_commitments.len() { | |||
| return Err(Status::invalid_argument( | |||
| "Amount of code commitments should not be larger than amount of requested accounts.", | |||
There was a problem hiding this comment.
nit: I would use "number" instead of "amount" here.
Mirko-von-Leipzig
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #520