-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(faucet): resume after restart #517
Merged
+437
−310
Merged
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
fcb66c7
feat: improve node errors
polydez 40a42f1
docs: update `CHANGELOG.md`
polydez 8873ba5
feat: save/restore faucet state and keypair to/from files
polydez 9053f12
feat: make faucet account public, request account state on submission…
polydez f984e67
feat: introduce `ClientError`
polydez 8e12b04
fix: update config
polydez 4fc851f
fix: save new faucet state to in-memory store after getting from the …
polydez cebc372
fix: remove `macros` feature from axum dependency
polydez be90b6b
docs: update `CHANGELOG.md`
polydez b808a80
docs: add comment for `seed` field
polydez dafc01b
fix: log message
polydez 50fd73e
refactor: address review comments
polydez 011002a
Merge branch 'next' into polydez-faucet-restore
polydez 8db4ae9
refactor: initial changes
Fumuran a78828f
refactor: impl Send and Sync for FaucetDataStore
Fumuran af6a0f3
chore: update changelog
Fumuran bf9bdc2
refactor: remove unnecessary async, add warning ignore to makefile
Fumuran 349c43b
refactor: update genesis generation, read faucet account from `faucet…
polydez bf0e97d
feat: faucet account creation
polydez c9f7fdd
fix: handling of account not found error
polydez 9e5d91d
refactor: use Arc and Mutex
bobbinth 738eae0
chore: removed unneeded cast
bobbinth df3a19b
fix: lint
bobbinth 915edf2
docs: update CHANGELOG.md
polydez 573f5c3
Merge branch 'refs/heads/andrew-migrate-to-miden-vm-0.11' into polyde…
polydez 4384a76
fix: compilation errors
polydez ea5d59c
docs: add `TODO` for incorrect and unsafe `Send` implementation
polydez f111115
refactor: small refactoring
polydez a6c37d0
Merge branch 'next' into polydez-faucet-restore
polydez 0a9f068
refactor: address review comments
polydez 112fcb6
docs: update `README.md` for faucet
polydez d0b8b5c
docs: improve instructions and clarifications in faucet's `README.md`
polydez 96d406d
Merge branch 'next' into polydez-faucet-restore
polydez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update step 1 in this file as well? I'm actually not sure if docker images work any more.
Also, is there some disconnect between step 1 and step 2? That is, if we run faucet in the testing mode, we should run node in the testing mode as well (maybe that's what's happening already, but I'd make it more explicit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes both should be in the same mode. I do wish we could make the difficulty configurable and not gated behind a compile time feature. Then we could decouple things by having an rpc endpoint to fetch the current difficulty of the node for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbinth,
I've checked, it works.
If we run node by using Docker, it's created in "testing" mode. All instructions in faucet's readme build node and faucet in "testing" mode. I've improved documentation in order to make it more descriptive about that.