BlockWitness: pass inputs to the VM through the advice provider
#516
Conversation
There was a problem hiding this comment.
Looks good! Thank you! Not a super deep review from me - but I did leave a couple of comments inline. The main one is about crating issues in miden-base to flash out inputs/outputs of batch and block kernels. If you create some basic issues, i'll try to fill in the details a bit later.
| let num_produced_nullifiers: Felt = (self.produced_nullifiers.len() as u64) | ||
| .try_into() | ||
| .expect("nullifiers number is greater than or equal to the field modulus"); | ||
| pub(super) fn into_program_inputs(self) -> Result<AdviceInputs, BlockProverError> { |
There was a problem hiding this comment.
I would probably still keep the old interface (i.e., return (AdviceInputs, StackInputs)) even if we currently return StackInput::default() for stack inputs.
| #! Inputs: | ||
| #! Operand stack: [] | ||
| #! Advice stack: [<account root inputs>, <note root inputs>, <nullifier root inputs>, <chain mmr root inputs>] | ||
| #! Advice map: { | ||
| #! PREV_CHAIN_MMR_HASH: [NUM_LEAVES, [peak_i], <maybe padding>] | ||
| #! } | ||
| #! Outputs: | ||
| #! Operand stack: [ACCOUNT_ROOT, NOTE_ROOT, NULLIFIER_ROOT, CHAIN_MMR_ROOT] | ||
| begin |
There was a problem hiding this comment.
This is fine for now, but we should be providing some inputs via the operand stack - otherwise this can be used to provide any arbitrary batch inputs.
Let's create 2 issues in miden-base for this: one issue for defining batch kernel inputs/outputs, and the other one for defining block kernel inputs/outputs.
There was a problem hiding this comment.
@bobbinth I created two issue templates: 0xPolygonMiden/miden-base#919 and 0xPolygonMiden/miden-base#920, although didn't manage to fill them properly, I'm not sure I understand what should be done.
Mirko-von-Leipzig
deleted the
andrew-block-witness-change-inputs-to-vm
branch
This PR refactors the
BlockWitness: it no longer uses the operand stack to provide the inputs to the VM, it uses only advice inputs instead.Closes: #78.