Added transaction number limit and updated tests to the limits introduced in miden-objects
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
approved these changes
Sep 23, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| - Optimized state synchronizations by removing unnecessary fetching and parsing of note details (#462). | |||
| - [BREAKING] Changed `GetAccountDetailsResponse` field to `details` (#481). | |||
| - Improve `--version` by adding build metadata (#495). | |||
| - [BREAKING] Introduced additional limits for note/asset/transaction number (#503). | |||
There was a problem hiding this comment.
The note and transaction limits are enforced in the batch builder, but where is the asset limit checked?
|
Not a full review, but as I mentioned in the A nice side effect of this should be an incentive to put transactions which touch the same account into a batch/block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue 0xPolygonMiden/miden-base#398
Here we use the latest
miden-objectswith updated/new limits. Also implemented checking for limits we can't check inmiden-objects. And also updated tests to the latestmiden-objectand added at least one asset in note mockups.