Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kernel root to blocks #496

Merged
merged 11 commits into from
Sep 13, 2024
Merged

feat: Add kernel root to blocks #496

merged 11 commits into from
Sep 13, 2024

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Sep 13, 2024

No description provided.

@igamigo igamigo requested review from bobbinth and polydez and removed request for bobbinth September 13, 2024 19:08
@igamigo igamigo requested a review from bobbinth September 13, 2024 19:12
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of minor comments inline.

crates/proto/src/domain/blocks.rs Outdated Show resolved Hide resolved
proto/block.proto Outdated Show resolved Hide resolved
proto/block.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@igamigo igamigo merged commit 9344a1d into next Sep 13, 2024
8 checks passed
@igamigo igamigo deleted the igamigo-kernel-root branch September 13, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants