Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AccountStub->AccountHeader, AccountStorageType->AccountStorageMode, docs and miden-base using next #489

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

SantiagoPittella
Copy link
Collaborator

This PR updates the miden-base dependency to use the GitHub repo, and in particular the next branch of the repo.

In that branch AccountStub and AccountStorageType were renamed to AccountHeader and AccountStorageMode respectively. This PR includes also renaming the stub's references in the doc to header.

…pe with AccountStorageMode, update docs, update miden-base to use next branch
@SantiagoPittella SantiagoPittella changed the title fix: AccountStub->AccountHeader, AccountStorageType->AccountStorageMode, docs and miden-base using next fix: AccountStub->AccountHeader, AccountStorageType->AccountStorageMode, docs and miden-base using next Sep 9, 2024
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SantiagoPittella SantiagoPittella merged commit 9567cf4 into next Sep 9, 2024
8 checks passed
@SantiagoPittella SantiagoPittella deleted the santiagopittella-use-next-from-base branch September 9, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants