feat: Add note execution_hint to store
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
approved these changes
Aug 12, 2024
crates/store/src/db/sql.rs
Outdated
| @@ -589,9 +600,15 @@ pub fn select_notes_since_block_by_tag_and_sender( | |||
| let merkle_path = MerklePath::read_from_bytes(merkle_path_data)?; | |||
| let details_data = row.get_ref(9)?.as_blob_or_null()?; | |||
| let details = details_data.map(<Vec<u8>>::read_from_bytes).transpose()?; | |||
| let execution_hint = row.get_ref(10)?.as_i64()? as u64; | |||
There was a problem hiding this comment.
I think we can use column_value_as_u64() here
crates/proto/src/domain/notes.rs
Outdated
| @@ -26,8 +33,15 @@ impl From<NoteMetadata> for crate::generated::note::NoteMetadata { | |||
| let sender = Some(val.sender().into()); | |||
| let note_type = val.note_type() as u32; | |||
| let tag = val.tag().into(); | |||
| let execution_hint: u64 = Felt::from(val.execution_hint()).into(); | |||
There was a problem hiding this comment.
I think we can now replace this with
let execution_hint: u64 = val.execution_hint().into();
bobbinth
reviewed
Aug 13, 2024
| aux INTEGER NOT NULL, | ||
| merkle_path BLOB NOT NULL, | ||
| details BLOB, | ||
| execution_hint INTEGER, |
There was a problem hiding this comment.
A couple of small comments:
- We should probably move
execution_hintto be right afterauxfield since logically it is part of the note's metadata. - I think
execution_hintshould beNOT NULLfield as we always have an integer value for it.
bobbinth
reviewed
Aug 13, 2024
crates/store/src/db/sql.rs
Outdated
Comment on lines
427
to
428
| details, | ||
| execution_hint |
There was a problem hiding this comment.
Similar to the other comment, here, and in other places in this file, I'd probably move execution_hint to be right after the aux field.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the faucet's and node build by doing the following:
execution_hintfield to Notes table.Closes #439 .
This PR is built on top of 0xPolygonMiden/miden-base#827 .
It is meant to be merged AFTER that PR.