feat: implement CheckNullifiersByPrefix endpoint
#419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomyrd
changed the title
check_nullifiers_by_prefix endpointCheckNullifiersByPrefix endpoint
tomyrd
force-pushed
the
tomyrd-get-nullifiers-by-prefix
branch
from
e06f52b to
04c5890
Compare
bobbinth
reviewed
Jul 25, 2024
tomyrd
force-pushed
the
tomyrd-get-nullifiers-by-prefix
branch
from
6588ea2 to
a1b32b7
Compare
bobbinth
approved these changes
Jul 26, 2024
5 tasks
Mirko-von-Leipzig
approved these changes
Jul 27, 2024
tomyrd
force-pushed
the
tomyrd-get-nullifiers-by-prefix
branch
from
a1b32b7 to
8875061
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #404
This is my first time implementing something in the node, I originally made this to better understand the node internals. Be sure to correct me if I missed something important in terms of validation or security.
This PR looks to add a new endpoint to the node that lets users check if a note is consumed without directly exposing its nullifier. In the next hours I'll also be adding a PR in the client that uses this endpoint to deal with imported notes.