On-chain accounts protobuf & domain objects #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polydez
force-pushed
the
polydez-onchain-accounts
branch
from
70b3098 to
530ac6e
Compare
polydez
changed the title
polydez
force-pushed
the
polydez-onchain-accounts
branch
from
aa83463 to
28d44fb
Compare
# Conflicts: # .gitignore # Cargo.toml
bobbinth
reviewed
Apr 1, 2024
hackaugusto
reviewed
Apr 1, 2024
proto/src/domain/notes.rs
Outdated
| @@ -25,7 +25,7 @@ impl From<(u64, NoteEnvelope)> for note::NoteCreated { | |||
| Self { | |||
| note_id: Some(note.note_id().into()), | |||
| sender: Some(note.metadata().sender().into()), | |||
| tag: note.metadata().tag().into(), | |||
| tag: u32::from(note.metadata().tag()).into(), | |||
There was a problem hiding this comment.
I think we should add the missing conversions to miden-base.
There was a problem hiding this comment.
@hackaugusto nice idea, done: 0xPolygonMiden/miden-base#559
There was a problem hiding this comment.
Eventually (in a different PR), tag here would be u32 as well, right
# Conflicts: # Cargo.lock # Cargo.toml # block-producer/src/block.rs # block-producer/src/block_builder/mod.rs # block-producer/src/test_utils/block.rs # block-producer/src/test_utils/proven_tx.rs # faucet/Cargo.toml # proto/src/errors.rs # store/src/state.rs
polydez
force-pushed
the
polydez-onchain-accounts
branch
from
26f1756 to
6eafe6e
Compare
bobbinth
approved these changes
Apr 5, 2024
bobbinth
pushed a commit
that referenced
this pull request
Apr 12, 2024
* feat: add `account_details` table to the DB * refactor: rename `block_number` column in nullifiers table to `block_num` * refactor: use `BETWEEN` in interval comparison checks * feat: implement account details protobuf messages, domain objects and conversions * feat: (WIP) implement account details support * feat: (WIP) implement account details support * feat: (WIP) implement account details support * feat: (WIP) implement account details support * fix: db creation * docs: remove TODO * refactor: apply formatting * feat: implement endpoint for getting public account details * tests: add test for storage * feat: add rpc endpoint for getting account details * refactor: keep only domain object changes * fix: compilation errors * fix: use note tag conversion from `u64` * refactor: remove account details protobuf messages * fix: remove unused error invariants * refactor: introduce `UpdatedAccount` struct * fix: rollback details conversion * fix: compilation error * format: reformat using rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be 1 of 3 PRs regarding support of on-chain (public) accounts in Miden node. This PR includes only implementation of protobuf and domain objects for on-chain accounts.