fix: type shadowing in proto file (#481)

* fix: change field name in `GetAccountDetailsResponse` * update: CHANGELOG
0xPolygonMiden · Sep 3, 2024 · 424a18c · 424a18c
1 parent 8dc465e
commit 424a18c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## v0.6.0 (TBD)
 
 - Optimized state synchronizations by removing unnecessary fetching and parsing of note details (#462).
+- [BREAKING] Changed `GetAccountDetailsResponse` field to `details` (#481).
 
 ## 0.5.0 (2024-08-27)
 

diff --git a/crates/proto/src/generated/responses.rs b/crates/proto/src/generated/responses.rs
@@ -201,7 +201,7 @@ pub struct ListNotesResponse {
 pub struct GetAccountDetailsResponse {
     /// Account info (with details for on-chain accounts)
     #[prost(message, optional, tag = "1")]
-    pub account: ::core::option::Option<super::account::AccountInfo>,
+    pub details: ::core::option::Option<super::account::AccountInfo>,
 }
 #[allow(clippy::derive_partial_eq_without_eq)]
 #[derive(Clone, PartialEq, ::prost::Message)]

diff --git a/crates/rpc-proto/proto/responses.proto b/crates/rpc-proto/proto/responses.proto
@@ -161,7 +161,7 @@ message ListNotesResponse {
 
 message GetAccountDetailsResponse {
     // Account info (with details for on-chain accounts)
-    account.AccountInfo account = 1;
+    account.AccountInfo details = 1;
 }
 
 message GetBlockByNumberResponse {

diff --git a/crates/store/src/server/api.rs b/crates/store/src/server/api.rs
@@ -335,7 +335,7 @@ impl api_server::Api for StoreApi {
             .map_err(internal_error)?;
 
         Ok(Response::new(GetAccountDetailsResponse {
-            account: Some((&account_info).into()),
+            details: Some((&account_info).into()),
         }))
     }
 

diff --git a/proto/responses.proto b/proto/responses.proto
@@ -161,7 +161,7 @@ message ListNotesResponse {
 
 message GetAccountDetailsResponse {
     // Account info (with details for on-chain accounts)
-    account.AccountInfo account = 1;
+    account.AccountInfo details = 1;
 }
 
 message GetBlockByNumberResponse {