feat: add Send to internal error
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomyrd
added
the
no changelog
bobbinth
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Looks good! Thank you!
On a quick glance I don't see issues with this, but also wonder what @PhilippGackstatter thinks.
PhilippGackstatter
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Looks good to me!
I think all the boxed dyn Errors should be Send + Sync + 'static but I forgot that on this one. I'll add it to the error issue: #972.
tomyrd
force-pushed
the
tomyrd-error-send
branch
from
f5e565e to
bf8b689
Compare
|
Forgot to set up commit signing. I just signed the same commit, I'll wait for the CI just to be sure before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the base branches to
nextin the Miden Client (0xPolygonMiden/miden-client#617), one of the errors is caused because an element ofAssetErroris notSend. By changing this line the error in the client is fixed (tested it locally).