feat: add conversion from Account to AccountDelta
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Looks good to me.
Ideally we would be implementing impl From<Account> instead of impl From<&Account> but it seems that all the recursive inner types all the way to miden crypto do not support into_* methods that consume the type and return the inner values. I think that would be overall more efficient, especially when one already has an Account and wants to convert to a delta without cloning.
Since this isn't an easy fix here, I think this PR is fine.
Co-authored-by: Philipp Gackstatter <[email protected]>
Co-authored-by: Philipp Gackstatter <[email protected]>
PhilippGackstatter
approved these changes
Nov 29, 2024
# Conflicts: # CHANGELOG.md
bobbinth
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to 0xPolygonMiden/miden-node#527
In this PR we implement conversion from account details to account "initial" delta. We need it in order to simplify DB requests which get delta's nonce/storage/storage-maps previous values.