Add error messages to miden-objects errors and implement core::error::Error
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
force-pushed
the
pgackst-refactor-errors
branch
from
08e9494 to
f9bd929
Compare
PhilippGackstatter
changed the title
miden-objects errors and implement core::error::Error
bobbinth
reviewed
Nov 20, 2024
bobbinth
approved these changes
Nov 21, 2024
PhilippGackstatter
force-pushed
the
pgackst-refactor-errors
branch
from
50357d2 to
f0fcad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor errors according to the guidelines in #966 in
miden-objectsand some small error-related changes in other crates.Part of #972. To close that issue, another PR needs to be made to update the remaining errors in miden-tx. I would split it in two parts in case there is feedback on these errors and I have to adjust some things.