Move pre-defined account components' source code into masm files #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Nov 8, 2024
Comment on lines
33
to
34
| /// This can be used in the assembly of programs that want to call procedures from this | ||
| /// component. |
There was a problem hiding this comment.
One thing to note is that all the procedures in the basic wallet are just re-exports from miden-lib, and so if miden-lib is imported into an assembler, there is no need to import basic wallet code separately.
On the other hand, basic wallet code relies on miden-lib, so - importing it without importing miden-lib will not be sufficient.
We should probably adjust the comment to reflect the above.
This reverts commit 33f158b.
PhilippGackstatter
force-pushed
the
pgackst-account-components-build
branch
from
a592b03 to
005e79e
Compare
PhilippGackstatter
added
the
no changelog
bobbinth
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #950
Move source code into masm files
Moves the source code of pre-defined account components into masm files in the
asm/account_componentsdirectory. Thebuild.rsscript will build all files in that directory.