feat: Encode NoteExecutionHint into NoteMetadata
#816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
changed the title
NoteExecutionHint into NoteMetadata
|
Is this ready for review or not yet? |
Yes, sorry for the confusion |
bobbinth
reviewed
Aug 8, 2024
3 tasks
bobbinth
approved these changes
Aug 9, 2024
Comment on lines
279
to
286
| # populate the metadata | ||
| # swap movup.4 movup.4 | ||
| movup.3 movup.3 push.TWO_POW_38 mul add movup.2 | ||
| # => [aux, encoded_type_and_ex_hint, tag] | ||
|
|
||
| # encode note_type and execution_hint into a single element | ||
| exec.account::get_id | ||
| # => [sender_acct_id, aux, encoded_type_and_ex_hint, tag] |
There was a problem hiding this comment.
A couple comments here:
- Line 280 should probably be deleted.
- Comment on line 284 should probably be moved to line 279.
- A new comment should probably be written on line 284.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #582