Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement send_note for basic wallet #808

Merged
merged 12 commits into from
Aug 9, 2024
Merged

Implement send_note for basic wallet #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8f302c6
feat: implement send_note procedure
Fumuran Jul 30, 2024
6cd8958
test: attempt to implement test for send_note
Fumuran Jul 30, 2024
058efec
feat: send_note without hash check
Fumuran Jul 31, 2024
1f643fe
feat: implement send_note with hash check
Fumuran Aug 1, 2024
fb3f2d9
refactor: divide send_note into two procedures
Fumuran Aug 2, 2024
3d9ca56
chore: update changelog, fix formatting in bench_tx/README
Fumuran Aug 2, 2024
5f295e8
refactor: simplify move_asset_to_note
Fumuran Aug 5, 2024
9b176ec
refactor: change add_asset_to_note procedure output, update tests
Fumuran Aug 8, 2024
3319b17
chore: update CHANGELOG
Fumuran Aug 8, 2024
b10e77a
refactor: optimize add_asset_to_note, update comments
Fumuran Aug 8, 2024
a8a3aab
refactor: update comments, update padding for called and syscalled procs
Fumuran Aug 9, 2024
9e3849c
refactor: update padding before calls
Fumuran Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
- [BREAKING] Refactored and simplified `NoteOrigin` and `NoteInclusionProof` structs (#810, #814).
- Made `miden_lib::notes::build_swap_tag()` function public (#817).
- [BREAKING] Changed the `NoteFile::NoteDetails` type to struct and added a `after_block_num` field (#823).
- Implemented `cteate_note` and `move_asset_into_note` basic wallet procedures (#808).
- [BREAKING] Interface of the `miden::tx::add_asset_to_note` procedure was changed (#808).

## 0.4.0 (2024-07-03)

Expand Down
123 changes: 82 additions & 41 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion bench-tx/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Miden transactions benchmark

This crate contains an executable used for benchmarking transactions.
This crate contains an executable used for benchmarking transactions.

For each transaction, data is collected on the number of cycles required to complete:

- Prologue
- All notes processing
- Each note execution
Expand Down
Loading
Loading